Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnail independent hidden badge #75

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mxmeinhold
Copy link
Contributor

@mxmeinhold mxmeinhold commented May 20, 2021

Currently, in the directory view, the only indicator that an image is hidden is a slight greying, which is a poor indicator on images that are primarily grey.

This adds a badge to make it obvious.

TODO

  • Test on dev
  • Upload screenshots

Resolves #54

@adamhb123
Copy link
Member

adamhb123 commented Aug 11, 2021

Evaluated to be functional in a local dev environment.

Badge shows properly, though it increases the height of the image container
Screenshot (blur added in post):
Badge image

The only way to fix this is either change the way the images are structured so as to allow space for badges, or position the badge absolutely.

I think it would be better both stylistically and pragmatically to do something like the following (quick drafts, with blur added in post):
Proposed solution images
This method indicates the fact that the image is hidden in the filename section, as well as having obvious, simple styling indicating that the image is unique.

Coloring could be adjusted to be more appealing, obviously (the contrast in the left image is egregious to say the least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden cards don't indicate they are hidden
2 participants