[WAL-1471] Add support for sponsored transactions #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix web-sdk compatibility
Update network connection
soerenbf
approved these changes
Dec 3, 2025
Collaborator
soerenbf
left a comment
soerenbf
left a comment
There was a problem hiding this comment.
Looks good to me! Only a few minor suggestions
| AccountTransactionType.Transfer | AccountTransactionType.Update | AccountTransactionType.InitContract | ||
| >; | ||
| payload: AccountTransactionPayload; | ||
| payload: AccountTransactionInput; |
Collaborator
There was a problem hiding this comment.
Might make it better to do
Suggested change
| payload: AccountTransactionInput; | |
| payload: Exclude<AccountTransactionInput, UpdateContractInput | InitContractInput | SimpleTransferPayload>; |
Comment on lines
+227
to
+230
| export type UpdateCredentialsPayloadCompat = | ||
| | UpdateCredentialsPayload | ||
| | UpdateCredentialsInput | ||
| | UpdateCredentialKeysInput; |
Collaborator
There was a problem hiding this comment.
I feel like this should be just
Suggested change
| export type UpdateCredentialsPayloadCompat = | |
| | UpdateCredentialsPayload | |
| | UpdateCredentialsInput | |
| | UpdateCredentialKeysInput; | |
| export type UpdateCredentialsPayloadCompat = UpdateCredentialsInput; |
?
soerenbf
reviewed
Dec 3, 2025
Collaborator
soerenbf
left a comment
soerenbf
left a comment
There was a problem hiding this comment.
I would suggest you create a dedicated branch for p10 features so you can still fix potential bugs on main without having to go back in history
Updates after review
This reverts commit 015c109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
_Describe the purpose of the pull request, link to issue describing the problem, etc.
Changes
_Describe the changes that were needed.
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.