Skip to content

Conversation

@soerenbf
Copy link
Collaborator

@soerenbf soerenbf commented Jan 13, 2026

Ref COR-2050

Purpose

Concordium/concordium-browser-wallet#658 can currently not use version 12.0.0 due to the following entrypoints not working:

  "exports": {
    ".": {
      "browser": {
        "module": "./lib/dapp/web/umd/index.min.js",
        "types": "./lib/dapp/web/esm/index.d.ts",
        "import": "./lib/dapp/web/esm/index.js",
        "default": "./lib/dapp/web/umd/index.min.js"
      },
    },
    "./dapp": {
      "browser": {
        "module": "./lib/dapp/web/umd/index.min.js",
        "types": "./lib/dapp/web/esm/index.d.ts",
        "import": "./lib/dapp/web/esm/index.js",
        "default": "./lib/dapp/web/umd/index.min.js"
      },
    },
    "./wallet": {
      "browser": {
        "module": "./lib/wallet/web/umd/index.min.js",
        "types": "./lib/wallet/web/esm/index.d.ts",
        "import": "./lib/wallet/web/esm/index.js",
        "default": "./lib/wallet/web/umd/index.min.js"
      },
    },
  },

Ideally when testing this, we should verify that the build works when used within https://github.com/Concordium/concordium-browser-wallet/

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf soerenbf self-assigned this Jan 13, 2026
@soerenbf soerenbf requested review from DOBEN and Ivan-Mahda January 13, 2026 20:19
@soerenbf soerenbf marked this pull request as draft January 14, 2026 05:41
@soerenbf soerenbf force-pushed the fix-rust-bindings-4 branch from bd59c04 to a64e0bf Compare January 14, 2026 12:06
@soerenbf soerenbf force-pushed the fix-rust-bindings-4 branch from a64e0bf to f6759dd Compare January 14, 2026 12:11
@soerenbf soerenbf marked this pull request as ready for review January 14, 2026 12:17
@soerenbf soerenbf marked this pull request as draft January 14, 2026 12:34
@soerenbf soerenbf changed the title Fix browser specific imports for the rust-bindings library. WIP: Fix browser specific imports for the rust-bindings library. Jan 14, 2026
@soerenbf soerenbf marked this pull request as ready for review January 14, 2026 13:43
@soerenbf
Copy link
Collaborator Author

Verified that this works in the context of the browser wallet.

@soerenbf soerenbf merged commit 6caf0ab into release/sdk/11.1.1 Jan 14, 2026
28 checks passed
@soerenbf soerenbf deleted the fix-rust-bindings-4 branch January 14, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants