Remove shuffling stable from fulu onwards - #11203
Open
gfukushima wants to merge 13 commits into
Open
Conversation
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
zilm13
previously approved these changes
Aug 31, 2026
zilm13
left a comment
zilm13
left a comment
Contributor
There was a problem hiding this comment.
LGTM
both comments are nit and optional
| import tech.pegasys.teku.spec.logic.common.statetransition.exceptions.SlotProcessingException; | ||
|
|
||
| @TestSpecContext(milestone = {BELLATRIX, FULU}) | ||
| class ForkChoiceUtilProposerHeadTest { |
Contributor
There was a problem hiding this comment.
Maybe ForkChoiceUtilReorgMilestoneTest?
The key purpose of this is to handle parameterized tests (compared to ForkChoiceUtilReorgTest)
| final boolean isProposerBoostActive = isProposerBoostActive(store, headNode.blockRoot()); | ||
| final boolean isShufflingStableAndForkChoiceOk = | ||
| isForkChoiceStableAndFinalizationOk(store, slot); | ||
| final boolean isProposerHeadReorgAllowed = isProposerHeadReorgAllowed(store, slot); |
Contributor
There was a problem hiding this comment.
isProposerHeadReorgAllowed is a very general name which combines all the conditions together. What i suggest:
isFinalizationOk
isProposerStable: >fulu? true : isShuffilngStable
2 of those are different by meaning if I understand it correctly, there were not many reasons to combine them before, and even less now with fulu change.
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
lucassaldanha
previously approved these changes
Sep 2, 2026
lucassaldanha
enabled auto-merge (squash)
September 2, 2026 21:41
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
gfukushima
dismissed stale reviews from zilm13 and lucassaldanha
via
September 9, 2026 23:09
dd1f835
zilm13
approved these changes
Sep 11, 2026
zilm13
disabled auto-merge
September 11, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Since the introduction of EIP 7917 (proposer lookahead) the shuffling in the proposers of the next epoch isn't possible at the last slot of the previous epoch. So from FULU onwards
isForkChoiceStableAndFinalizationOkgets simplified to the single checkisFinalizationOkFixed Issue(s)
Fixes #11150
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes consensus-adjacent fork-choice re-org behavior at epoch boundaries on Fulu; mistakes could alter which block validators propose on, though scope is limited to late-block re-org paths and is covered by new milestone tests.
Overview
Aligns late-block proposer re-org with Fulu (EIP-7917) by splitting the old combined gate into
isProposerStableandisFinalizationOkingetProposerHead. Pre-Fulu, proposer stability still means shuffling-stable (not at an epoch boundary); from Fulu,ForkChoiceUtilFulutreats the proposer as always stable because lookahead fixes assignments before the epoch boundary, so epoch-first-slot re-orgs are no longer blocked solely by shuffling stability.shouldOverrideForkChoiceUpdate(Teku-only FCU optimization) still requiresisShufflingStableat all milestones, with an explicit comment that payload prep on the parent stays conservative at epoch boundaries.Adds
ForkChoiceUtilReorgMilestoneTest(Bellatrix vs Fulu at epoch boundary) and updates existing re-org tests and specrefs forget_proposer_head#fulu.Reviewed by Cursor Bugbot for commit 195f36f. Bugbot is set up for automated code reviews on this repo. Configure here.