11261 update gossip rules - #11270
Open
mehdi-aouadi wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 095c1e1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Description
Update Gloas gossip rules for beta 0 spec
Fixed Issue(s)
fixes #11261
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes which gossip messages are accepted, ignored, or queued across EPBS paths; misalignment with the spec or lookahead logic could drop valid traffic or admit invalid messages.
Overview
Aligns Gloas gossip validation with the beta 0 spec: rule comments, ordering, and several new or tightened checks across payload attestations, execution payload bids/envelopes, and proposer preferences.
GossipValidationHelperaddsisWithinProposerLookaheadandisWithinParentProposerLookahead(MIN_SEED_LOOKAHEAD / clock disparity). Execution payload bids now IGNORE bids whose slot is past the parent block’s proposer lookahead, and split gas-limit vs. parent-payload checks to match the spec; fee-recipient mismatch stays IGNORE. Proposer preferences dedupe runs earlier, IGNORE pre-Gloas epochs, use the new lookahead helper, and require dependent-block state viagetStateAtBlockRootbefore checkpoint validation. Payload attestations REJECT out-of-range validator indices and route all outcomes through shared trace logging with validator/slot/block context.Tests cover lookahead helpers, bid lookahead, blob limits, builder index/version, payload attestation bounds, and the updated proposer-preferences paths.
Reviewed by Cursor Bugbot for commit e47c059. Bugbot is set up for automated code reviews on this repo. Configure here.