Skip to content

fix: graceful HTTP server shutdown with in-flight request draining - #1210

Open
enriquevalenzuelagalaxy wants to merge 5 commits into
Consensys-Incorporated:masterfrom
GalaxyDigitalPublic:ev/upstream/graceful-http-shutdown
Open

fix: graceful HTTP server shutdown with in-flight request draining#1210
enriquevalenzuelagalaxy wants to merge 5 commits into
Consensys-Incorporated:masterfrom
GalaxyDigitalPublic:ev/upstream/graceful-http-shutdown

Merge branch 'master' into ev/upstream/graceful-http-shutdown

bd4bb58
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 15, 2026 in 21s

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 250 in core/src/main/java/tech/pegasys/web3signer/core/Runner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "e" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26XX7Ck9GhP6XbjC&open=AZ9c26XX7Ck9GhP6XbjC&pullRequest=1210

Check warning on line 248 in core/src/test/java/tech/pegasys/web3signer/core/RunnerGracefulShutdownTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "expected" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c4CMoYTMT2AZx_ssA&open=AZ9c4CMoYTMT2AZx_ssA&pullRequest=1210

Check failure on line 134 in core/src/test/java/tech/pegasys/web3signer/core/RunnerGracefulShutdownTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26cN7Ck9GhP6XbjF&open=AZ9c26cN7Ck9GhP6XbjF&pullRequest=1210

Check warning on line 224 in core/src/test/java/tech/pegasys/web3signer/core/RunnerGracefulShutdownTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "ignored" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26cN7Ck9GhP6XbjI&open=AZ9c26cN7Ck9GhP6XbjI&pullRequest=1210

Check warning on line 230 in core/src/main/java/tech/pegasys/web3signer/core/Runner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "e" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26XX7Ck9GhP6XbjB&open=AZ9c26XX7Ck9GhP6XbjB&pullRequest=1210

Check warning on line 204 in core/src/test/java/tech/pegasys/web3signer/core/RunnerGracefulShutdownTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "e" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26cN7Ck9GhP6XbjH&open=AZ9c26cN7Ck9GhP6XbjH&pullRequest=1210

Check warning on line 299 in core/src/main/java/tech/pegasys/web3signer/core/Runner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "e" with an unnamed pattern. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26XX7Ck9GhP6XbjD&open=AZ9c26XX7Ck9GhP6XbjD&pullRequest=1210

Check warning on line 84 in core/src/test/java/tech/pegasys/web3signer/core/RunnerGracefulShutdownTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "getDataPath" on line 79. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26cN7Ck9GhP6XbjG&open=AZ9c26cN7Ck9GhP6XbjG&pullRequest=1210

Check warning on line 385 in core/src/main/java/tech/pegasys/web3signer/core/Runner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "httpServer" which hides the field declared at line 93. 

See more on https://sonarcloud.io/project/issues?id=ConsenSys_web3signer&issues=AZ9c26XX7Ck9GhP6XbjE&open=AZ9c26XX7Ck9GhP6XbjE&pullRequest=1210
View more details on SonarQubeCloud