Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

removed functionality of txReciepts #89

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

sunnya97
Copy link
Contributor

@sunnya97 sunnya97 commented Jun 12, 2017

Addresses #75

Copy link
Contributor

@webthethird webthethird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough

@jo-tud
Copy link
Contributor

jo-tud commented Jun 13, 2017

I love this - however, it moves EthOn a big step away from the protocol specification. Therefore, please merge into dev ( @webthethird ).

@webthethird Please make sure the illustrations reflect this major change.

Here's the full rationale for the record:
Transaction Receipts are used by Ethereum nodes to persist information that can only be known after processing a transaction. In EthOn we just attach this additional information to the Tx itself, once it is known. There is no need to make the model more complex by adding Receipts because EthOn is not a specification for client implementation (unlike the YP).

@webthethird webthethird merged commit 84823dc into Consensys:master Jun 13, 2017
@webthethird
Copy link
Contributor

@jo-tud My apologies, I merged into master instead of the dev branch. Should I revert this and continue on the dev branch?

@webthethird
Copy link
Contributor

@jo-tud The main illustration didn't include TxReceipts originally, so there is nothing to remove there. I am going to go over the other illustrations and update them according to the new changes.

@jo-tud
Copy link
Contributor

jo-tud commented Jun 13, 2017

Yes, please revert and then merge into dev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants