Skip to content

Commit

Permalink
erge branch 'master' of github.com:ConsenSys/gnark
Browse files Browse the repository at this point in the history
  • Loading branch information
gbotrel committed Oct 12, 2023
2 parents 80fb122 + 438d154 commit 61b5e9c
Show file tree
Hide file tree
Showing 20 changed files with 23 additions and 23 deletions.
4 changes: 2 additions & 2 deletions backend/groth16/bn254/solidity.go
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ contract Verifier {
/// @notice Reverts with InvalidProof if the proof is invalid or
/// with PublicInputNotInField the public input is not reduced.
/// @notice There is no return value. If the function does not revert, the
/// proof was succesfully verified.
/// proof was successfully verified.
/// @param compressedProof the points (A, B, C) in compressed format
/// matching the output of compressProof.
/// @param input the public input field elements in the scalar field Fr.
Expand Down Expand Up @@ -487,7 +487,7 @@ contract Verifier {
/// @notice Reverts with InvalidProof if the proof is invalid or
/// with PublicInputNotInField the public input is not reduced.
/// @notice There is no return value. If the function does not revert, the
/// proof was succesfully verified.
/// proof was successfully verified.
/// @param proof the points (A, B, C) in EIP-197 format matching the output
/// of compressProof.
/// @param input the public input field elements in the scalar field Fr.
Expand Down
2 changes: 1 addition & 1 deletion backend/plonk/bls12-377/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonk/bls12-381/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonk/bls24-315/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonk/bls24-317/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonk/bn254/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions backend/plonk/bn254/solidity.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonk/bw6-633/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonk/bw6-761/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonkfri/bls12-377/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonkfri/bls12-381/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonkfri/bls24-315/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonkfri/bls24-317/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonkfri/bn254/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonkfri/bw6-633/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/plonkfri/bw6-761/setup.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion constraint/core.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ func (system *System) CheckSerializationHeader() error {

if binaryVersion.Compare(objectVersion) != 0 {
log := logger.Logger()
log.Warn().Str("binary", binaryVersion.String()).Str("object", objectVersion.String()).Msg("gnark version (binary) mismatch with constraint system. there are no guarantees on compatibilty")
log.Warn().Str("binary", binaryVersion.String()).Str("object", objectVersion.String()).Msg("gnark version (binary) mismatch with constraint system. there are no guarantees on compatibility")
}

// TODO @gbotrel maintain version changes and compare versions properly
Expand Down
4 changes: 2 additions & 2 deletions examples/rollup/error.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import "errors"

var (
// ErrSizeByteSlice memory checking
ErrSizeByteSlice = errors.New("byte slice size is inconsistant with Account size")
ErrSizeByteSlice = errors.New("byte slice size is inconsistent with Account size")

// ErrNonExistingAccount account not in the database
ErrNonExistingAccount = errors.New("the account is not in the rollup database")
Expand All @@ -31,7 +31,7 @@ var (
// ErrAmountTooHigh the amount is bigger than the balance
ErrAmountTooHigh = errors.New("amount is bigger than balance")

// ErrNonce inconsistant nonce between transfer and account
// ErrNonce inconsistent nonce between transfer and account
ErrNonce = errors.New("incorrect nonce")

// ErrIndexConsistency the map publicKey(string) -> index(int) gives acces to the account position.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func BuildTrace(spr *cs.SparseR1CS, pt *Trace) {
qk := make([]fr.Element, size)
qcp := make([][]fr.Element, len(commitmentInfo))

for i := 0; i < len(spr.Public); i++ { // placeholders (-PUB_INPUT_i + qk_i = 0) TODO should return error is size is inconsistent
for i := 0; i < len(spr.Public); i++ { // placeholders (-PUB_INPUT_i + qk_i = 0) TODO should return error if size is inconsistent
ql[i].SetOne().Neg(&ql[i])
qr[i].SetZero()
qm[i].SetZero()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func Setup(spr *cs.SparseR1CS) (*ProvingKey, *VerifyingKey, error) {
pk.LQkIncompleteDomainSmall = make([]fr.Element, pk.Domain[0].Cardinality)
pk.CQkIncomplete = make([]fr.Element, pk.Domain[0].Cardinality)

for i := 0; i < len(spr.Public); i++ { // placeholders (-PUB_INPUT_i + qk_i = 0) TODO should return error is size is inconsistant
for i := 0; i < len(spr.Public); i++ { // placeholders (-PUB_INPUT_i + qk_i = 0) TODO should return error if size is inconsistent
pk.EvaluationQlDomainBigBitReversed[i].SetOne().Neg(&pk.EvaluationQlDomainBigBitReversed[i])
pk.EvaluationQrDomainBigBitReversed[i].SetZero()
pk.EvaluationQmDomainBigBitReversed[i].SetZero()
Expand Down

0 comments on commit 61b5e9c

Please sign in to comment.