Groth 16 MPC setup refactor #1297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
…into chore/groth16-mpc
|
It seems the CI check fails due to Consensys/gnark-crypto#585 - here now in both cases encode and encodeRaw we encode the G1/G2 points as compressed, but Solidity checker assumes uncompressed it seems. When I reverted gnark-crypto upgrade then the failing test started to pass. But I think it is better to fix the other PR. |
Yes that's it. Thank you! Just pushed a fix to the other PR. |
|
Closed in favor of #1372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Groth16 MPC setup to support BSB22 commitments.