Skip to content

Conversation

@viktorking7
Copy link

@viktorking7 viktorking7 commented Sep 29, 2025

Description

  • Summary: Replace a shadowed assignment that prevented creating a zero polynomial when n == -1.
  • Problem: In getRandomPolynomial, a was redeclared with a := under n == -1, leaving the outer slice nil and failing to cancel blinding as intended.
  • Fix: Change a := make(... to a = make(... so the outer variable is set.
  • Impact: Ensures correct “cancel the blinding” behavior.

Note

Fixes shadowed assignment in getRandomPolynomial so n == -1 yields a zero polynomial across all PLONK backends and the template.

  • PLONK backends:
    • Update getRandomPolynomial in backend/plonk/{bls12-377,bls12-381,bls24-315,bls24-317,bn254,bw6-633,bw6-761}/prove.go to assign a = make(...) (not a := ...) when n == -1, ensuring a zero polynomial and disabling blinding.
  • Code generation template:
    • Apply the same fix in internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl.

Written by Cursor Bugbot for commit 0517697. This will update automatically on new commits. Configure here.

@ivokub ivokub added type: typo Fixes typos in comments or documentation src: community Community originating PRs and issues labels Oct 7, 2025
@ivokub ivokub changed the base branch from master to typo/fixes-v15 November 25, 2025 14:30
@ivokub ivokub merged commit 8552830 into Consensys:typo/fixes-v15 Nov 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

src: community Community originating PRs and issues type: typo Fixes typos in comments or documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants