-
Notifications
You must be signed in to change notification settings - Fork 21
feat: integrate trm assembly module #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Constraints (AIR)
|
;; discount address 0 | ||
if low == 0 goto exit_0 | ||
;; determine low <= MAX_PRC_ADDRESS | ||
b,tmp = low - MAX_PRC_ADDRESS - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work for Osaka (soon ...) as it introduces a new precompiles at 0x100
: https://eips.ethereum.org/EIPS/eip-7951
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, well that's good to know. But, we can update it to support that when the time comes easily enough.
6f8c94d
to
26f022b
Compare
This integrates an assembly implementation of the trm module, including those constants necessary to distinguish the different numbers of precompiles in different forks.
26f022b
to
909def3
Compare
This integrates an assembly implementation of the trm module, including those constants necessary to distinguish the different numbers of precompiles in different forks.
Constraints (MIR)
Full constraints for this module:
Note
Integrates zkasm-based TRM function and updates lookups and fork-specific constants to the new RAW_ADDRESS/ADDRESS_HI interface.
trm/columns.lisp
,trm/constants.lisp
,trm/constraints.lisp
) and WCP lookup with zkasm implementationtrm/trm.zkasm
exposingtrm(RAW_ADDRESS u256) -> (ADDRESS_HI u32, IS_PRECOMPILE u1)
.hub/*/lookups/hub_into_trm.lisp
,rlpaddr/lookups/rlpaddr_into_trm.lisp
, andrlptxn/cancun/lookups/rlptxn_into_trm.lisp
to usetrm.RAW_ADDRESS
(combinedHI/LO
) andtrm.ADDRESS_HI
; remove legacyIOMF
/per-word columns.MAX_PRC_ADDRESS
to zkasm (constants/*/constants.zkasm
), removing.lisp
constants.Makefile
to reference.zkasm
constants andTRM := trm/trm.zkasm
.Written by Cursor Bugbot for commit 909def3. This will update automatically on new commits. Configure here.