-
Notifications
You must be signed in to change notification settings - Fork 21
Prover column after TXN_DATA
redesign
#796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
(defproperty prover-column-constraints---RELATIVE_USER_TXN_NUMBER---transition (if-not-zero (- (next BLK_NUMBER) BLK_NUMBER) (vanishes! RELUSR))) | ||
(defproperty prover-column-constraints---RELATIVE_USER_TXN_NUMBER---increment (if-not-zero (- (next BLK_NUMBER) (+ BLK_NUMBER 1)) | ||
(eq! (next RELUSR) | ||
(* (next USER) (+ RELUSR (- (next USER_TXN_NUMBER) USER_TXN_NUMBER)))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Block Number Mismatch Causes Increment Error
The RELATIVE_USER_TXN_NUMBER---increment
property's condition (if-not-zero (- (next BLK_NUMBER) (+ BLK_NUMBER 1)))
applies increment logic when (next BLK_NUMBER)
is not BLK_NUMBER + 1
. This conflicts with the RELUSR
column's definition, which resets it to 0
on any block number change, leading to inconsistent behavior.
Note
Adds prover columns and constraints for relative/user transaction tracking across txndata variants, wires USER_TXN_NUMBER_MAX from rlptxn into txndata, and makes perspective-sum explicitly binary.
txndata/{cancun,osaka,prague}
:prover___RELATIVE_USER_TXN_NUMBER
,prover___IS_LAST_USER_TXN_OF_BLOCK
with properties.prover___RELATIVE_USER_TXN_NUMBER_MAX
,prover___USER_TXN_NUMBER_MAX
with constancy/finalization constraints.rlptxn/cancun
:prover___USER_TXN_NUMBER_MAX
with constancy/finalization constraints.rlptxn/cancun/lookups/rlptxn_into_txndata.lisp
to maprlptxn.prover___USER_TXN_NUMBER_MAX
→txndata.prover___USER_TXN_NUMBER_MAX
.txndata/prague/generalities/flags_perspectives.lisp
: makeperspective-sum
binary viaforce-bin
.Written by Cursor Bugbot for commit 30ed81e. This will update automatically on new commits. Configure here.