-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(CALL): zero size, huge return at offset, huge call data offset, huge return data offset #1448
base: arith-dev
Are you sure you want to change the base?
test(CALL): zero size, huge return at offset, huge call data offset, huge return data offset #1448
Conversation
This, or something related, should be blowing up in the first of the tests, the one about Lines 164 to 179 in cab035d
|
System.out.println("callDataOffset: " + callDataOffset); | ||
System.out.println("callDataSize: " + callDataSize); | ||
System.out.println("returnAtOffset: " + returnAtOffset); | ||
System.out.println("returnDataSize: " + returnAtCapacity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
System.out.println("callDataOffset: " + callDataOffset); | ||
System.out.println("callDataSize: " + callDataSize); | ||
System.out.println("returnAtOffset: " + returnAtOffset); | ||
System.out.println("returnAtCapacity: " + returnAtCapacity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't explain the HUB tracing not blowing up 🤔.
@lorenzogentile404 We also need simple unit tests that trigger this behaviour. |
At this point, the purpose of this PR is just adding some tests as described in the title. Fixed to MXP tests have been already merged into arith-dev by @DavePearce. |
No description provided.