Feat/multi transaction with create tests #1615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes GAS_NEXT issues for now
amkCha
changed the title
|
Note that you are currently changing the commit for the constraints in this PR. Check that's what you intended. It could be that after updating to HEAD of arith-dev this will be resolved. |
amkCha
force-pushed
the
feat/multi-transaction-with-create-tests
branch
from
28117c5 to
cc3a374
Compare
|
This PR is apparently building off of some PR of mine I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1590
have the world deal with everything in between (nonce updates, deployments, balance changes, ...)
==> change worldStateUpdater.commit() place in
testing/src/main/java/net/consensys/linea/testing/GeneralStateReferenceTestTools.javawhen defining the transactions only use Addresses to refer to accounts
The nonce is a private parameter in a Transaction so once the Transaction is built, it cannot be changed. What we can feed ToyMultiTransaction with is a list of ToyTransactionBuilders i/o ToyTransactions and then go
final List<Transaction> transactions = ToyMultiTransaction.builder().build(toyTransactionBuilders, userAccount);We can use the Address as well vs the Account. It requires a search in the HashMap addressToAccount though and I'm not sure I see it adds more value - TBD