Skip to content

Conversation

letypequividelespoubelles
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles commented Oct 1, 2025

Note

Remove ProcessableBlockHeader-based traceStartBlock overload, consolidating on (BlockHeader, BlockBody) signature and updating Wcp module and tests accordingly.

  • Tracing API:
    • Remove traceStartBlock(WorldView, ProcessableBlockHeader, Address) from ZkTracer and Wcp; use traceStartBlock(WorldView, BlockHeader, BlockBody, Address).
  • Tests/Callers:
    • Update LineCountingTracerTest and BlockchainReferenceTestTools to pass BlockBody (e.g., BlockBody.empty() or block.getBody()).
    • Add necessary BlockBody imports and adjust method invocations.

Written by Cursor Bugbot for commit d39cad4. This will update automatically on new commits. Configure here.

@letypequividelespoubelles letypequividelespoubelles linked an issue Oct 1, 2025 that may be closed by this pull request
cursor[bot]

This comment was marked as outdated.

Signed-off-by: F Bojarski <[email protected]>
cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Transaction Commit Issue in WCP Module

The removal of traceStartBlock in Wcp.java means additionalRows.commitTransactionBundle() is no longer called at block start. This prevents additionalRows from properly committing its state, potentially causing incorrect line counting and state management in the WCP module.

arithmetization/src/main/java/net/consensys/linea/zktracer/module/wcp/Wcp.java#L91-L110

additionalRows.commitTransactionBundle();
}
@Override
public void popTransactionBundle() {
for (ModuleOperationStackedSet<WcpOperation> operationsSet : operations) {
operationsSet.popTransactionBundle();
}
additionalRows.popTransactionBundle();
}
@Override
public void tracePreOpcode(MessageFrame frame, OpCode opcode) {
if (opcode == LT
|| opcode == GT
|| opcode == SLT
|| opcode == SGT
|| opcode == EQ
|| opcode == ISZERO) {

Fix in Cursor Fix in Web


@letypequividelespoubelles letypequividelespoubelles marked this pull request as draft October 1, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rm traceStartBlock duplicate
1 participant