Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releases/2.1.0 #77

Closed
wants to merge 2 commits into from
Closed

Releases/2.1.0 #77

wants to merge 2 commits into from

Conversation

CDR-AidenJ
Copy link
Contributor

Checklist: (Put an x in all the boxes that apply)

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that there aren't any other open Pull Requests from the same change.
  • The develop branch has been set as the base branch to merge changes of the pull request.
  • I have updated the CHANGELOG.md file as appropriate.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
v2.1.0 release

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

CDR-CI and others added 2 commits August 14, 2024 05:56
@CDR-CI
v2.1.0 release
41206e9
@CDR-AidenJ
Docker changes
0c6a314 
1. Update action steps to their latest versions.
2. Pass the build platform as a variable to target for the given platform
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 16, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2024
View reviewed changes
Source/CDR.DCR/DCRHttpClientHandler.cs

if (dcrOptions.Ignore_Server_Certificate_Errors)
{
ServerCertificateCustomValidationCallback += (sender, cert, chain, sslPolicyErrors) => true;

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AZFYwhsSnP80dNfWOaSg-->Enable server certificate validation on this SSL/TLS connection <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFYwhsSnP80dNfWOaSg&open=AZFYwhsSnP80dNfWOaSg&pullRequest=77">SonarCloud</a></p>
Source/CDR.DataRecipient.Web/Controllers/DataSharingControllerBase.cs
@@ -227,13 +231,11 @@
protected virtual async Task<ConsentArrangement> GetCdrArrangement(HttpRequest request)
{
// Get the cdr arrangement id from the http header.
if (!request.Headers.ContainsKey(HEADER_INJECT_CDR_ARRANGEMENT_ID))
if (!request.Headers.TryGetValue(HEADER_INJECT_CDR_ARRANGEMENT_ID, out var cdrArrangementId))

Check warning

Code scanning / SonarCloud

Use model binding instead of reading raw request data

<!--SONAR_ISSUE_KEY:AZFYwhqUnP80dNfWOaP7-->Use model binding instead of accessing the raw request data <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFYwhqUnP80dNfWOaP7&open=AZFYwhqUnP80dNfWOaP7&pullRequest=77">SonarCloud</a></p>
Source/CDR.DataRecipient.Web/Controllers/JwksController.cs
@@ -35,17 +32,17 @@
[HttpGet]
[Route("jwks/{id:int?}")]
[ServiceFilter(typeof(LogActionEntryAttribute))]
public async Task<IActionResult> GetJwks(int? id = 1)
public IActionResult GetJwks(int? id = 1)

Check failure

Code scanning / SonarCloud

ModelState.IsValid should be called in controller actions

<!--SONAR_ISSUE_KEY:AZFYwhq4nP80dNfWOaQW-->ModelState.IsValid should be checked in controller actions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFYwhq4nP80dNfWOaQW&open=AZFYwhq4nP80dNfWOaQW&pullRequest=77">SonarCloud</a></p>
Source/CDR.DataRecipient.Web/Controllers/JwksController.cs
}

[HttpGet]
[Route("jwks-with-private-keys/{id:int?}")]
[ServiceFilter(typeof(LogActionEntryAttribute))]
public async Task<IActionResult> GetJwksPrivateKeys(int? id = 1)
public IActionResult GetJwksPrivateKeys(int? id = 1)

Check failure

Code scanning / SonarCloud

ModelState.IsValid should be called in controller actions

<!--SONAR_ISSUE_KEY:AZFYwhq4nP80dNfWOaQX-->ModelState.IsValid should be checked in controller actions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFYwhq4nP80dNfWOaQX&open=AZFYwhq4nP80dNfWOaQX&pullRequest=77">SonarCloud</a></p>
Source/CDR.DiscoverDataHolders/DHHttpClientHandler.cs
ClientCertificates.Add(clientCertificate);
if (dhOptions.Ignore_Server_Certificate_Errors)
{
ServerCertificateCustomValidationCallback += (sender, cert, chain, sslPolicyErrors) => true;

Check failure

Code scanning / SonarCloud

Server certificates should be verified during SSL/TLS connections

<!--SONAR_ISSUE_KEY:AZFYwhr6nP80dNfWOaSS-->Enable server certificate validation on this SSL/TLS connection <p>See more on <a href="https://sonarcloud.io/project/issues?id=ConsumerDataRight_mock-data-recipient&issues=AZFYwhr6nP80dNfWOaSS&open=AZFYwhr6nP80dNfWOaSS&pullRequest=77">SonarCloud</a></p>
@CDR-AidenJ CDR-AidenJ closed this Aug 19, 2024
@CDR-FarooqK CDR-FarooqK deleted the releases/2.1.0 branch August 22, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDR-FarooqK CDR-FarooqK Awaiting requested review from CDR-FarooqK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CDR-AidenJ @CDR-CI