Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic strength Indicator and added a feature to show very strong, strong, moderate, weak #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Durgaprasad-Developer
Copy link

@Durgaprasad-Developer Durgaprasad-Developer commented Oct 8, 2024

Description

Major: added a new feature in strength Indicator and live updating indicator color and new feature
Minor: changed initial length from 8 to 12 and increased max length from 20 to 25

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related Issue

Dynamic color change and add text feature which says strong, moderate, weak based on user checked
Make the Password Strength Indicator dynamic

Fixes #8 #1

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motivation and Context

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

Screenshot from 2024-10-09 02-04-57

Screenshot from 2024-10-09 02-05-22

Screenshot from 2024-10-09 02-05-45

Checklist:

  • I have registered myself at Contrihub website.
  • My code follows the code style of this project.
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Any dependent changes have been merged and published in downstream modules
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

added style to new strength Indicator
Major:
 changes added a new feature in strength Indicator and live updating indicator color and new feature 

Minor:
changed Initial length to 12 from 10 so that it will make strong password 
Changed max length from 20 to 25
Mentioned what changes made
@Durgaprasad-Developer Durgaprasad-Developer changed the title new feature in strength Indicator and live updating indicator color and new feature Dynamic strength Indicator Oct 8, 2024
@Durgaprasad-Developer Durgaprasad-Developer changed the title Dynamic strength Indicator Dynamic strength Indicator and added a feature to show very strong, strong, moderate, weak Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic color change and add text feature which says strong, moderate, weak based on user checked
1 participant