feat: share emoji's in video conferencing #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@silkie261001 then i will apply those styling and complete the pr |
|
here's the progress so far webrtc.mp4.webm |
|
Like you can create one bar containing emojis in the video call container.
…On Fri, Oct 13, 2023, 10:29 AM lokesh-wagh ***@***.***> wrote:
@silkie261001 <https://github.com/silkie261001>
Mam the PR is not complete yet i just wanted you to suggest some styling
like where should the shared emoji's appear
then i will apply those styling and complete the pr
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASRKYI7HEMRLVE6GAGL43VLX7DDEZANCNFSM6AAAAAA56EFXIE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
i have a pop up for picking emoji's |
|
Yes, you can do that.
…On Fri, Oct 13, 2023, 11:36 AM lokesh-wagh ***@***.***> wrote:
i have a pop up for picking emoji's
should i add a bar below with some commonly used emoji's??
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASRKYI77TOLT6F2RHVR5V6LX7DK6JANCNFSM6AAAAAA56EFXIE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
and where should the sent emoji pop?? |
|
It can pop anywhere in the stream in mid or bottom, anywhere as per you
convenience.
…On Fri, Oct 13, 2023, 11:38 AM lokesh-wagh ***@***.***> wrote:
and where should the sent emoji pop??
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASRKYI3DDBGQG6N4KPHIECDX7DLGTANCNFSM6AAAAAA56EFXIE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
screen-capture.5.webmadded the bar |
|
@silkie261001 i have explained all the change's by updating the first comment of the PR thread |
|
@silkie261001 |
silkie261001
approved these changes
Oct 13, 2023
|
Thank you for guidance mam!! |
|
You have done a great job.
…On Fri, Oct 13, 2023 at 9:49 PM lokesh-wagh ***@***.***> wrote:
Thank you for guidance mam!!
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASRKYIZWQIK4O6XVWDL2SHTX7FSX3ANCNFSM6AAAAAA56EFXIE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have fixed some bug's that were preventing the deployment of the project's
I have fixed send friend invitation (no invite was being sent)
then i have added a component to pick emoji's
i have also enabled json data to be transferred over P2P connection (which i have used for sharing emoji's)
in the first few files i have just replaced process.env with my own secret string so that newcomer's don't get thrown with a lot of error's
then in backend/socketServer file i have made the server listening to the port that it was supposed to listen at
then in frontend/src/Dashboard/FriendsSideBar/AddFriendButton.js i have added a method that would actually send the invite to the backend
frontend/src/Dashboard/FriendsSideBar/AddFriendButton.js here i have added the actual emoji sidebar
frontend/src/Dashboard/Room/RoomButtons/emojiButton.js here the emoji tray has been added that can be used to send various emoji's
frontend/src/Dashboard/Room/RoomButtons/RoomButtons.js
here i have added the Emoji Picker to room button's so that it can be accesible
in frontend/src/Dashboard/Room/VideosContainer.js i have added a new styled div by the name of VideoWrapper
this div contain's both the div that is displaying the emoji and the video as well
frontend/src/realtimeCommunication/socketConnection.js i have stored the socket id in localstorage for access later
in frontend/src/realtimeCommunication/webRTCHandler.js i have added a exchange data event to all the peer's and three method's
handleExchangeData : facilitate's the exchange of data through peer's
AddEmoji : add's the emoji to it's right video container and also remove's it from there after 2s
getPeer's : return's the active peer's object
Related Issue
Fixes #7
Closes #7
Type of change
Motivation and Context
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Screenshots (if appropriate):
Checklist:
Test Configuration: