Update version, deps, and include <0% formatting fix #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
reviewed
Feb 8, 2025
| @@ -1,4 +1,4 @@ | |||
| always-auth=true | |||
| registry=https://registry.npmjs.org/ | |||
| @cookiemonsterteam:registry=https://npm.pkg.github.com | |||
| //npm.pkg.github.com/:_authToken=${GITHUB_REGISTERY_PAT} | |||
| //npm.pkg.github.com/:_authToken=${GITHUB_REGISTRY_PAT} | |||
There was a problem hiding this comment.
You can't change this without also changing the name of the key in .github/workflows/CI.yml.
| @@ -0,0 +1 @@ | |||
| nodejs 16.20.2 | |||
There was a problem hiding this comment.
What is this file used for? I have never seen it
| @@ -133,7 +133,7 @@ export function UpdateTimerBar() { | |||
| updateChanceTotal(chanceToSpawn); | |||
| l('CMTimerBarGCTime').textContent = `${Math.ceil( | |||
| (Game.shimmerTypes.golden.maxTime - Game.shimmerTypes.golden.time) / Game.fps, | |||
| )} ${getChanceFinal() < 0.01 ? '<' : ''}${getChanceFinal().toLocaleString('en', { | |||
| )} ${getChanceFinal() < 0.01 ? '<' : ''}${(0.01).toLocaleString('en', { | |||
There was a problem hiding this comment.
I would prefer to not include this in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the version number to match the latest, updated some dependencies, cleaned up/ignored some lint issues, and included the formatting fix from #1192. Oh, and fixed the misspelling in the env var in the npmrc.
Let me know if there's anything else I should do for now.