Skip to content

fix: advertise Codex as stdio-only (#1193) #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scriptwonder merged 2 commits into from
Jul 28, 2026
Merged

fix: advertise Codex as stdio-only (#1193) #1292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff8ff8
fix: advertise Codex as stdio-only (#1193)
Scriptwonder Jul 28, 2026
afc51b5
fix: force stdio in the Codex manual snippet, assert the exact transp…
Scriptwonder Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion MCPForUnity/Editor/Clients/Configurators/CodexConfigurator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ public CodexConfigurator() : base(new McpClient
name = "Codex",
windowsConfigPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".codex", "config.toml"),
macConfigPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".codex", "config.toml"),
linuxConfigPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".codex", "config.toml")
linuxConfigPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".codex", "config.toml"),
SupportsHttpTransport = false
})
{ }

Expand All @@ -30,5 +31,8 @@ public override string GetSkillInstallPath()
"Paste the configuration TOML",
"Save and restart Codex"
};

private static readonly ConfiguredTransport[] StdioOnly = { ConfiguredTransport.Stdio };
public override IReadOnlyList<ConfiguredTransport> SupportedTransports => StdioOnly;
}
Comment on lines +35 to 37
}
11 changes: 11 additions & 0 deletions TestProjects/UnityMCPTests/Assets/Tests/EditMode/Clients/SupportedTransportsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@ public void ClaudeDesktop_SupportsStdioOnly()
CollectionAssert.DoesNotContain(claude.SupportedTransports.ToList(), ConfiguredTransport.Http);
}

[Test]
public void Codex_SupportsStdioOnly()
{
// Regression guard for #1193: Codex does not expose tools over the HTTP block, so it
// must advertise stdio only and let CoerceTransportFor pick stdio before Configure().
var codex = new CodexConfigurator();
CollectionAssert.Contains(codex.SupportedTransports.ToList(), ConfiguredTransport.Stdio);
CollectionAssert.DoesNotContain(codex.SupportedTransports.ToList(), ConfiguredTransport.Http);
Assert.IsFalse(codex.Client.SupportsHttpTransport, "Codex must not be treated as HTTP-capable");
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

[Test]
public void Cursor_SupportsBothTransports()
{
Expand Down
Loading