-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix/port discovery missing imports #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8ae595d
Update github-repo-stats.yml
dsarno 83b16ea
Merge branch 'CoplayDev:main' into main
dsarno 67be840
Merge branch 'CoplayDev:main' into main
dsarno f7ce27d
Merge branch 'CoplayDev:main' into main
dsarno 83b9e47
Merge branch 'CoplayDev:main' into main
dsarno 9dff8f1
Merge branch 'CoplayDev:main' into main
dsarno 00fad91
Merge branch 'main' of https://github.com/CoplayDev/unity-mcp into main
dsarno 74d35d3
Server: refine shutdown logic per bot feedback\n- Parameterize _force…
dsarno 1bb280e
Revert "Server: refine shutdown logic per bot feedback\n- Parameteriz…
dsarno e6cc955
Merge branch 'CoplayDev:main' into main
dsarno 532b30d
Merge branch 'CoplayDev:main' into main
dsarno 5939d23
Merge branch 'CoplayDev:main' into main
dsarno 9549dd4
Merge branch 'CoplayDev:main' into main
dsarno 6ed7a35
Merge branch 'main' of https://github.com/CoplayDev/unity-mcp
dsarno aeceec3
Merge branch 'main' of github.com:dsarno/unity-mcp
dsarno 2d7844c
fix: Add missing os and struct imports to port_discovery.py
dsarno d7cbbfb
Fix: Resolve absolute path for uvx to support Claude Desktop on macOS
dsarno e613607
fix: Add missing os and struct imports to port_discovery.py
dsarno d463aa5
Fix: Resolve absolute path for uvx to support Claude Desktop on macOS
dsarno b264bed
Merge branch 'fix/port-discovery-missing-imports' of https://github.c…
dsarno 2850af8
Merge branch 'main' of https://github.com/CoplayDev/unity-mcp into fi…
dsarno 293bd1f
fix: resolve Windows path issue in uv cache clearing (preserve .exe e…
dsarno 7bfad3b
fix: wrap uvx in cmd /c for Windows clients to ensure PATH resolution
dsarno 42b8eef
Fix: Increase port discovery timeout to 1.0s and fix uv cache cleanin…
dsarno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questionable fallback behavior could produce invalid paths.
The fallback on line 38 removes the last character when "uvx" is not found in the path. This is problematic:
Consider handling this case more defensively:
Apply this diff to improve the fallback behavior:
Alternatively, if the original behavior was intentional for specific edge cases, document why with a comment explaining the use case.
🤖 Prompt for AI Agents