-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add --offline to uvx launches for faster startup (#760) #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7128a35
Add --offline flag to uvx launches for faster startup when cache is w…
dsarno 863d08d
Centralize uvx dev-flags logic and cache offline probe result
dsarno c3665d1
Move cache fields above methods and avoid redundant ShouldForceUvxRef…
dsarno 173322f
Skip stdio migration for clients incompatible with current transport
dsarno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
TestProjects/UnityMCPTests/Assets/Tests/EditMode/Helpers/AssetPathUtilityOfflineTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| using NUnit.Framework; | ||
| using MCPForUnity.Editor.Helpers; | ||
| using MCPForUnity.Editor.Constants; | ||
| using UnityEditor; | ||
|
|
||
| namespace MCPForUnityTests.Editor.Helpers | ||
| { | ||
| public class AssetPathUtilityOfflineTests | ||
| { | ||
| private bool _originalForceRefresh; | ||
|
|
||
| [SetUp] | ||
| public void SetUp() | ||
| { | ||
| _originalForceRefresh = EditorPrefs.GetBool(EditorPrefKeys.DevModeForceServerRefresh, false); | ||
| } | ||
|
|
||
| [TearDown] | ||
| public void TearDown() | ||
| { | ||
| EditorPrefs.SetBool(EditorPrefKeys.DevModeForceServerRefresh, _originalForceRefresh); | ||
| } | ||
|
|
||
| [Test] | ||
| public void ShouldUseUvxOffline_WhenForceRefreshEnabled_ReturnsFalse() | ||
| { | ||
| EditorPrefs.SetBool(EditorPrefKeys.DevModeForceServerRefresh, true); | ||
| Assert.IsFalse(AssetPathUtility.ShouldUseUvxOffline()); | ||
| } | ||
|
|
||
| [Test] | ||
| public void ShouldUseUvxOffline_DoesNotThrow() | ||
| { | ||
| EditorPrefs.SetBool(EditorPrefKeys.DevModeForceServerRefresh, false); | ||
| Assert.DoesNotThrow(() => AssetPathUtility.ShouldUseUvxOffline()); | ||
| } | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
...Projects/UnityMCPTests/Assets/Tests/EditMode/Helpers/AssetPathUtilityOfflineTests.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.