Validate notification expiration timestamps on registration - #112
Merged
Abd-Standard merged 1 commit intoJun 20, 2026
Merged
Conversation
- reject invalid Date objects with a descriptive error - reject timestamps at or before current time (expired) - validate executeAt string in REST endpoint before Date construction - add boundary tests: past, now, invalid date, 1s future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #96
What
Prevents registration of notifications with invalid or already-expired
executeAttimestamps.Changes
notification-api.ts— split the single vague guard into two checks:Invalid Dateobjects:executeAt must be a valid dateexecuteAt must be a future timestamp — the provided date has already expiredevents-server.ts— validates the rawexecuteAtstring before constructing aDate, returning400early instead of passing anInvalid Datesilently downstreamnew Date('not-a-date')(invalid Date object)Testing
All 30 tests pass.