-
Notifications
You must be signed in to change notification settings - Fork 2
CKE-92 catalog and workspace protocol #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the monorepo to use pnpm's catalog and workspace protocols for dependency management. The catalog feature centralizes version definitions in pnpm-workspace.yaml, while the workspace protocol enables proper resolution of internal packages.
Key changes:
- Introduced a catalog section in
pnpm-workspace.yamldefining versions for all external dependencies - Replaced explicit version numbers with
catalog:references for external dependencies across all package.json files - Replaced version-pinned internal dependencies with
workspace:*protocol for proper monorepo package resolution - Converted CommonJS module syntax to ES modules in Jest configuration files
Reviewed Changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added catalog section defining centralized versions for all external dependencies |
| packages/*/package.json (25 files) | Updated to use catalog protocol for external dependencies and workspace protocol for internal dependencies |
| package.json | Migrated root package dependencies to use catalog protocol |
| app/package.json | Migrated application dependencies to use catalog protocol |
| itest/package.json | Migrated integration test dependencies to use catalog protocol |
| itest/jest*.js (3 files) | Converted from CommonJS to ES modules (require → import, module.exports → export default) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/ckeditor5-coremedia-studio-integration-mock/package.json
Outdated
Show resolved
Hide resolved
…ith catalog protocol
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 35 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.