Skip to content

Enhance CI workflow with security and reproducibility #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CorentynDevPro merged 4 commits into from
Nov 21, 2025
Merged

Enhance CI workflow with security and reproducibility #4

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af307c0
Enhance CI workflow with security and reproducibility
CorentynDevPro Nov 20, 2025
e4da794
Initial plan
Copilot Nov 20, 2025
46f5ff1
Apply review comments to CI workflow
Copilot Nov 20, 2025
e917405
Merge pull request #5 from CorentynDevPro/copilot/sub-pr-4
CorentynDevPro Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 52 additions & 37 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,47 +2,52 @@ name: CI/CD Pipeline

on:
push:
branches: [main, develop]
branches: [ main, develop ]
pull_request:
branches: [main, develop]
branches: [ main, develop ]

# Minimal permissions to reduce token exposure
permissions:
contents: read

jobs:
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'

- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8

- name: Get pnpm store directory
id: pnpm-cache
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT

- name: Setup pnpm cache
uses: actions/cache@v3
with:
path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-

- name: Install dependencies
run: pnpm install

# Use frozen lockfile for reproducible installs
run: pnpm install --frozen-lockfile

- name: Run ESLint
run: pnpm run lint

- name: Check Prettier formatting
run: pnpm run format:check

Expand All @@ -51,34 +56,34 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'

- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8

- name: Get pnpm store directory
id: pnpm-cache
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT

- name: Setup pnpm cache
uses: actions/cache@v3
with:
path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-

- name: Install dependencies
run: pnpm install
run: pnpm install --frozen-lockfile

- name: Run type checking
run: pnpm run type-check

Expand All @@ -87,74 +92,84 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'

- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8

- name: Get pnpm store directory
id: pnpm-cache
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT

- name: Setup pnpm cache
uses: actions/cache@v3
with:
path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-

- name: Install dependencies
run: pnpm install
run: pnpm install --frozen-lockfile

- name: Run tests
run: pnpm run test

- name: Upload coverage artifact (if produced)
if: always()
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using if: always() will attempt to upload artifacts even when the test step is skipped or cancelled, not just on failure. Consider using if: success() || failure() instead to only upload when tests actually run but potentially fail, avoiding unnecessary uploads when the workflow is cancelled or skipped.

Suggested change
if: always()
if: success() || failure()

Copilot uses AI. Check for mistakes.
uses: actions/upload-artifact@v3
with:
name: coverage-report
path: |
coverage
coverage/**/*
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path specification is redundant. The pattern coverage already matches the directory and coverage/**/* adds no additional coverage. Simplify to just coverage/ to capture the entire directory contents.

Suggested change
path: |
coverage
coverage/**/*
path: coverage/

Copilot uses AI. Check for mistakes.
retention-days: 7

build:
name: Build
runs-on: ubuntu-latest
needs: [lint, type-check, test]
needs: [ lint, type-check, test ]
steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'

- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8

- name: Get pnpm store directory
id: pnpm-cache
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT

- name: Setup pnpm cache
uses: actions/cache@v3
with:
path: ${{ steps.pnpm-cache.outputs.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-

- name: Install dependencies
run: pnpm install
run: pnpm install --frozen-lockfile

- name: Build all packages
run: pnpm run build

- name: Upload build artifacts
uses: actions/upload-artifact@v3
with:
Expand All @@ -167,14 +182,14 @@ jobs:
docker:
name: Build Docker Images
runs-on: ubuntu-latest
needs: [build]
needs: [ build ]
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker job builds and caches Docker images but has only contents: read permission. If this job needs to use GitHub Actions cache (type=gha), it requires actions: write permission. Consider adding job-level permissions or documenting that the cache operations may fail silently with the current minimal permissions.

Suggested change
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
permissions:
contents: read
actions: write

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v4

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Build backend image
uses: docker/build-push-action@v5
with:
Expand All @@ -184,7 +199,7 @@ jobs:
tags: starforge-backend:latest
cache-from: type=gha
cache-to: type=gha,mode=max

- name: Build bot image
uses: docker/build-push-action@v5
with:
Expand Down
Loading