-
Notifications
You must be signed in to change notification settings - Fork 0
[fix] windows cortex-engine exec for v0.1.10 Release #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,11 +3,14 @@ | |
| mod environment; | ||
| mod output; | ||
| mod policy; | ||
| #[cfg(any(target_os = "linux", target_os = "macos"))] | ||
| // Process-group teardown is Unix-only; the runner itself is required on Windows | ||
| // so local_shell / plugin exec still compile (job-object isolation is separate). | ||
| #[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows"))] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This change enables the runner on Windows, but full-access commands receive neither process-group cleanup nor Job Object ownership. When a timeout occurs, the runner kills only the immediate child; descendants it started can remain running after the command is reported as timed out. Artifacts
|
||
| mod runner; | ||
| pub use environment::{build_safe_environment, is_sensitive_env_name}; | ||
|
|
||
| pub use output::OutputCapture; | ||
| #[cfg(any(target_os = "linux", target_os = "macos", target_os = "windows"))] | ||
| pub use runner::{ | ||
| ExecOptions, ExecOutput, OutputChunk, execute_command, execute_command_streaming, | ||
| }; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change enables the command runner on Windows, but
ReadOnlyandWorkspaceWritecommands still enter the legacy sandbox preparation path. That path rejects non-full-access policies on Windows before spawning the command, so local-shell and plugin commands using the normal restricted policies fail instead of running.Artifacts
Evidence from the check
Command output from the check
Command output from the check
Evidence from the check
Command output from the check
Command output from the check