[audit] Cortex CLI 100% TUI+MCP (Fable) - #48
Conversation
Co-authored-by: Mathis <echobt@users.noreply.github.com>
Greptile SummarySummaryThe lock-board index describes Merge safetySafe to merge, with a non-blocking documentation accuracy correction recommended so readers do not assume the fixture comparison already runs. Confidence Score: 4/5Safe to merge; the remaining issue is a non-blocking documentation accuracy concern in the lock-board index. The documentation claim was confirmed against the audit, the production source tree, and the existing uniqueness-test results. Files Needing Attention: design/cli-lock-board-index.md
What T-Rex did
|
| Every v2 id is covered by `lock_v2_wide_frames_are_unique` (and | ||
| `lock_v2_narrow_frames_are_unique` when narrow = yes) and by | ||
| `lock.diff_txt` against `docs/media/tui-lock-v2/txt/<size>/<id>.txt`. |
There was a problem hiding this comment.
Planned verifier listed as coverage
This non-blocking coverage statement says lock.diff_txt currently verifies every v2 ID, but the accompanying audit defines that verifier as proposed and unimplemented. The uniqueness tests run today, but readers cannot rely on fixture comparison yet. Describe lock.diff_txt as planned coverage until it is implemented.
| Every v2 id is covered by `lock_v2_wide_frames_are_unique` (and | |
| `lock_v2_narrow_frames_are_unique` when narrow = yes) and by | |
| `lock.diff_txt` against `docs/media/tui-lock-v2/txt/<size>/<id>.txt`. | |
| Every v2 id is covered by `lock_v2_wide_frames_are_unique` (and | |
| `lock_v2_narrow_frames_are_unique` when narrow = yes). The proposed | |
| `lock.diff_txt` verifier will compare each id against | |
| `docs/media/tui-lock-v2/txt/<size>/<id>.txt`. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Artifacts
- The exact Bash validator authored and executed to inspect the documentation, run the existing uniqueness tests, and search production Rust source; it makes the verification reproducible.
- Output from executing the validator in `/home/user/repo`, showing three passing uniqueness tests, no production `lock.diff_txt` implementation match, and the confirmed documentation inconsistency.
Summary
Docs-only A→Z audit of Cortex CLI / Cortex Code at
main3035361(v0.1.10), so Mathis can see whether the CLI works at 100 % against the product and Designer cli locks, and so the fix agents get an ordered, file:line-cited plan.docs/audits/CORTEX_CLI_100_AUDIT_2026-09-08.md— locks vs tree, 149-id lock state matrix (72 v1 + 77/31 v2), surface-by-surface gaps with evidence, what already works, DoD, verification-MCP spec (tools / resources / JSON report), ordered P0→P2 fix PRs, flow acceptance matrix, open Designer questions. Ends withCLI_100_AUDIT_READY.design/cli-lock-board-index.md— every lock id → source kind (live / painted / synthetic) → covering test → verifier tool / flow.docs/README.md— one index row (docs rule).Designer lock recorded as green focus
#1F4945(Mathis LOCK GO); violet#A78BFArecorded as historical. Code implements green; every committed lock PNG pack is still violet andscripts/render-tui-lock.shstill asserts violet (P0 drift, cited).Headline findings (all cited in the audit): default first turn refused (
ComputerKinddefaults to This PC,ensure_sessionrequires Cloud; observed withcortex exec),/auth/mehard-coded to production before the TUI opens, verification MCP does not exist (cortex mcp-serverbails "not yet implemented";cortex-mcp-servercrate is unused), permission prompt runtime widget ≠ lock radios, login transport errors not product-facing, third-party vendor model ids in--help/ aliases / a second provider entry.No application code changes. Nothing in the document is a pass rate that was not produced by a command run for this audit.
Test plan
cargo test --locked -p cortex-tui -p cortex-core— cortex-core 406 passed / 0 failed / 2 ignored; cortex-tui 1 062 passed / 0 failed / 7 ignored (evidence for the audit, no code touched)cargo build --locked -p cortex-cliand binary probes in an isolatedHOME(--help,mcp-server,debug doctor --json,exec --jsonandmodels listagainst a loopback URL, TTY refusal); no live API requestcargo fmt --all -- --check/./scripts/clippy.sh/cargo audit— not applicable to a docs-only diff; CI runs themAttestation (required)
I attest that:
Risk
None to runtime. The audit itself proposes P0 changes (Cloud default,
/v1/meorigin, verifier MCP, lock regeneration) that carry auth/API-contract impact when implemented — each is scoped in §7 with the rule it satisfies.