Conversation
0533c87 to
155cc18
Compare
155cc18 to
96c2652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PlatformNetwork/bounty-challenge#21930 — Folder scope in Settings does not behave as folder-only.
Problem
When the user selects 'Folder' scope in the Settings dialog, the settings panels still read and write settings at the global/user level instead of folder-specific. The
settingsScope()signal is correctly set to'folder'but the individual setting controls call genericsetSetting()/updateEditorSetting()etc. instead ofsetFolderSetting(folderPath, section, key, value).Solution
SettingsDialog.tsx
folderPath={selectedFolder()}to all sub-panels when scope is'folder'setFolderSetting()/hasFolderOverride()/resetFolderSetting()All 7 Sub-Panels (Editor, Files, Terminal, Network, Git, Debug, Workbench)
folderPath?: stringto each panel's props interfaceupdateSetting(): Addedscope() === 'folder'check → callssettings.setFolderSetting()hasOverride(): Addedscope() === 'folder'check → callssettings.hasFolderOverride()resetOverride(): Addedscope() === 'folder'check → callssettings.resetFolderSetting()settings.getEffectiveSettingsForPath(folderPath)when in folder scopeNo changes needed in SettingsContext
All folder-level APIs (
setFolderSetting,resetFolderSetting,hasFolderOverride,getEffectiveSettingsForPath,loadFolderSettings,saveFolderSettings) already existed inSettingsContext.tsxand were fully implemented.Verification
npm run build✅npm run typecheck✅