fix: wire Documentation activity bar button to correct sidebar tab (fixes PlatformNetwork/bounty-challenge#21919)#13
Closed
fix: wire Documentation activity bar button to correct sidebar tab (fixes PlatformNetwork/bounty-challenge#21919)#13
Conversation
echobt
force-pushed
the
fix/issue-21919
branch
from
9de77a5 to
96c2652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Wires the Documentation button in the Activity Bar to correctly render the CortexDocumentationPanel in the sidebar.
Changes
CortexActivityBar.tsx: Added 'docs' tab entry with correct icon and labelCortexSidebarContainer.tsx: Added conditional rendering ofCortexDocumentationPanelwhensidebarTab === 'docs'Root Cause
Clicking 'Documentation' in the Activity Bar set the sidebar tab to a value that didn't match what the sidebar container checked for rendering
CortexDocumentationPanel.Fixes PlatformNetwork/bounty-challenge#21919