fix: settings Modified filter now correctly detects nested setting changes (fixes PlatformNetwork/bounty-challenge#21918)#14
Closed
fix: settings Modified filter now correctly detects nested setting changes (fixes PlatformNetwork/bounty-challenge#21918)#14
Conversation
echobt
force-pushed
the
fix/issue-21918
branch
from
8aaa18f to
96c2652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The Settings 'Modified' filter now correctly detects changes in nested settings objects.
Changes
SettingsContext.tsx: ImplementedcountDeepDifferences()andcollectDeepDifferences()utility functions for recursive deep comparison of nested settings objectsgetModifiedCountForSection()now uses deep comparison instead of shallow reference checkseditor.inlayHints,zenMode.*,theme.*), arrays, and primitive values correctlyRoot Cause
getModifiedCount()only compared top-level keys against defaults using reference equality. Nested objects likeinlayHints: { enabled: true, fontSize: 12 }were compared by reference to the default object and always appeared 'equal', causing the Modified filter to show an empty sidebar.Fixes PlatformNetwork/bounty-challenge#21918