fix: prevent JSON Settings Editor header actions from clipping on resize (fixes PlatformNetwork/bounty-challenge#21915)#15
Closed
fix: prevent JSON Settings Editor header actions from clipping on resize (fixes PlatformNetwork/bounty-challenge#21915)#15
Conversation
echobt
force-pushed
the
fix/issue-21915
branch
from
c16454f to
96c2652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Prevents the JSON Settings Editor header action buttons from being clipped after window resize.
Changes
JsonSettingsEditor.tsx: Addedflex-wrapandgap-2to the header container so it wraps gracefullyflex-shrink-0to the actions container so buttons don't collapsemin-w-0on flex children that should truncate (title/breadcrumb) rather than the action buttonsflex-wrap min-w-0to allow wrapping at narrow widthsRoot Cause
The header bar used flexbox but the actions container (buttons for copy, reset, etc.) had no shrink protection, causing them to collapse and clip when the window was resized narrower.
Fixes PlatformNetwork/bounty-challenge#21915