fix: preserve Settings Editor TOC section state across focus changes (fixes PlatformNetwork/bounty-challenge#21908)#17
Closed
fix: preserve Settings Editor TOC section state across focus changes (fixes PlatformNetwork/bounty-challenge#21908)#17
Conversation
4f0bbac to
96c2652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Preserves the Settings Editor TOC (Table of Contents) section state across editor focus changes.
Changes
SettingsEditor.tsx: Module-level signalpersistedActiveSectionis now backed by sessionStorage viasafeGetItem/safeSetItemsettings_active_toc_sectionensures persistence across component unmount/remount cyclesRoot Cause
When the editor gained/lost focus, the SettingsEditor component could re-mount (due to
<Show>/<Switch>wrappers), and the module-level signal would be reset to 'editor' (default). The fix backs the signal with sessionStorage so it survives these cycles.Fixes PlatformNetwork/bounty-challenge#21908