Conversation
…fic settings (fixes PlatformNetwork/bounty-challenge#21930) When the user selects 'Folder' scope in Settings, all settings panels now correctly use folder-specific APIs instead of falling through to user/workspace level: - All 7 sub-panels (Editor, Files, Terminal, Network, Git, Debug, Workbench) updated to accept folderPath prop and check for folder scope - updateSetting() now calls setFolderSetting() when scope is 'folder' - hasOverride() now calls hasFolderOverride() when scope is 'folder' - resetOverride() now calls resetFolderSetting() when scope is 'folder' - Settings display reads from getEffectiveSettingsForPath() for folder scope - Inline settings in SettingsDialog (theme, wrapTabs, sortOrder) also handle folder scope with proper read/write/reset - Added folder scope indicator badges (green) to all panels - Reset buttons show folder-specific text when in folder scope - SettingsDialog passes selectedFolder() as folderPath to all sub-panels - wrapTabs override indicator dot correctly reflects folder overrides
echobt
changed the title
Contributor
Author
|
Closing: this fix has already been applied directly to the main branch. The branch is based on an older commit and merging it would regress other fixes. The referenced issue is resolved on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for PlatformNetwork/bounty-challenge#21930: Folder-scoped settings not wired in Settings Dialog
Changes
setFolderSettingandresetFolderSettingfunctions to settings panelsscopeandfolderPathpropsFiles Modified
src/components/SettingsDialog.tsxsrc/components/settings/DebugSettingsPanel.tsxsrc/components/settings/EditorSettingsPanel.tsxsrc/components/settings/FilesSettingsPanel.tsxsrc/components/settings/GitSettingsPanel.tsxsrc/components/settings/NetworkSettingsPanel.tsxsrc/components/settings/TerminalSettingsPanel.tsxsrc/components/settings/WorkbenchSettingsPanel.tsx