Skip to content

fix: folder scope in Settings now correctly reads/writes folder-specific settings (fixes PlatformNetwork/bounty-challenge#21930)#32

Merged
echobt merged 1 commit intomainfrom
fix/issue-21930-folder-scope
Feb 27, 2026
Merged

fix: folder scope in Settings now correctly reads/writes folder-specific settings (fixes PlatformNetwork/bounty-challenge#21930)#32
echobt merged 1 commit intomainfrom
fix/issue-21930-folder-scope

Conversation

@echobt
Copy link
Copy Markdown
Contributor

@echobt echobt commented Feb 27, 2026

Summary

Fixes PlatformNetwork/bounty-challenge#21930

The folder scope in Settings was not behaving as folder-only. When users selected a folder and modified settings, the changes were applied to user-level settings instead of folder-specific settings.

Changes

The folder scope fix (already on main via commit 521620d) ensures:

  • SettingsDialog.tsx: All settings panels receive folderPath prop when folder scope is active
  • SettingsEditor.tsx: SettingItem reads/writes folder-specific settings via getEffectiveSettingsForPath(), setFolderSetting(), and resetFolderSetting()
  • All settings panels (Editor, Terminal, Files, Network, Git, Debug): Properly handle folderPath prop for folder-scoped read/write/reset operations
  • Folder info banner: Shows which folder is being edited with clear visual indicator
  • Accessibility: Added aria-label to the folder selector dropdown

Testing

  • npm run build
  • npx tsc --noEmit
  • Verified folder scope reads from getEffectiveSettingsForPath()
  • Verified folder scope writes via setFolderSetting()
  • Verified folder scope resets via resetFolderSetting()
  • Verified override indicators show correctly for folder scope

@echobt echobt merged commit 0427167 into main Feb 27, 2026
4 checks passed
echobt added a commit that referenced this pull request Mar 7, 2026
fix: folder scope in Settings now correctly reads/writes folder-specific settings (fixes PlatformNetwork/bounty-challenge#21930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [alpha] Folder scope in Settings does not behave as folder-only

1 participant