fix(server): add optional TLS and block insecure binds#18
Open
fix(server): add optional TLS and block insecure binds#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why\nRunning
vgrep serveon a non-loopback interface can expose search results (including code snippets) over cleartext HTTP.\n\n## What\n- Add optional TLS support for the server viaaxum-serverusingVGREP_TLS_CERT/VGREP_TLS_KEY(or--tls-cert/--tls-key).\n- Refuse to bind to non-loopback addresses without TLS unless explicitly overridden withVGREP_ALLOW_INSECURE_HTTP=true(or--allow-insecure-http).\n- Update server banner to showhttps://when TLS is enabled.\n\n## Tests\n- Integration tests cover refusal onVGREP_HOST=0.0.0.0without TLS and the insecure override path.