fix: reject empty queries in search and embed endpoints#23
Open
fix: reject empty queries in search and embed endpoints#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation to the
/search,/embed, and/embed_batchendpoints to reject empty or whitespace-only inputs.Changes
searchhandler to return 400 Bad Request if query is empty or whitespace.embedhandler to return 400 Bad Request if text is empty or whitespace.embed_batchhandler to return 400 Bad Request if the list is empty or contains only empty strings.src/server/api_tests.rs.Reason
Empty queries waste resources by generating embeddings and searching the database for meaningless input. This validation prevents unnecessary computation and returns a clear error to the client.