Open
Conversation
This change introduces atomic database operations for file and chunk insertions. Previously, files and chunks were inserted in separate operations, which could lead to inconsistent states (orphan files) if the process was interrupted. Now, insertions are wrapped in a transaction, ensuring that either all data is persisted or none of it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #155 where database operations for inserting files and chunks were not atomic. This could lead to orphan records if the process was interrupted between inserting a file and its chunks.
Changes
insert_file_with_chunksmethod toDatabasewhich wraps file and chunk insertion in a single transaction.Indexer,ServerIndexer, andFileWatcherto use this new method.Verification
Related Issue
Fixes #155