fix: sanitize host configuration to prevent HTTP header injection#41
Open
fix: sanitize host configuration to prevent HTTP header injection#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a security vulnerability (HTTP Header Injection / CRLF Injection) where unsanitized user input in the
hostconfiguration allowed attackers to inject arbitrary HTTP headers into outgoing requests.Changes
Client::newinsrc/server/client.rsto sanitize thehostparameter.\r), Line Feed (\n), and Null (\0) characters from the host string before constructing thebase_url.Verification
Related Issue
Fixes #179