Conversation
Registers a global panic hook that checks if the terminal is in raw mode (TUI active) and restores it (leaves alternate screen, disables mouse capture, shows cursor) before printing the panic message. This prevents the terminal from being left in a broken state if the TUI panics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where a panic within the TUI (or while the terminal is in raw mode) would leave the terminal in a broken state (raw mode enabled, cursor hidden, alternate screen active).
Changes
src/cli/mod.rs(the entry point for CLI commands).crossterm::terminal::is_raw_mode_enabled()to determine if cleanup is necessary.Verification
cargo checkandcargo testpass.crosstermandratatuipanic handling patterns, adapted for global application to avoid TUI-local wrapper complexity.