Open
Conversation
This introduces a write_atomic helper that writes to a temporary file first and then renames it to the target path. This ensures that if the process is interrupted during write, the target file remains intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #134 regarding non-atomic saves of configuration files. Previously, config files were written directly, which could lead to corruption if the process was interrupted during the write operation.
Changes
uuiddependency to generate unique temporary filenames.write_atomichelper function in a newutils.rsmodule.write_atomicwrites content to a temporary file first, then renames it to the target path.Config::saveinsrc/config.rsto usewrite_atomic.src/cli/install.rsto usewrite_atomic.Verification
tests/atomic_write_test.rsto verify the atomic write behavior (creates file, overwrites file, handles directories).cargo testsuccessfully.