fix: validate embedding count in indexer to prevent panic#46
Open
fix: validate embedding count in indexer to prevent panic#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the indexer could panic with an "index out of bounds" error if the embedding engine returned fewer embeddings than the number of chunks provided.
Changes
Indexer::index_directoryto ensure the number of returned embeddings matches the number of chunks.ServerIndexer::index_directoryto ensure the number of returned embeddings matches the number of chunks, both per-batch and for the total count.Reasoning
When the embedding API fails silently or partially (e.g., due to timeouts, memory limits, or network issues), it may return a partial list of embeddings. iterating over the chunks and accessing the embeddings by index without validation led to a panic. This fix ensures the application handles this failure mode gracefully.
Testing