fix: enable foreign key constraints in SQLite connection#47
Open
fix: enable foreign key constraints in SQLite connection#47
Conversation
This change enables foreign key enforcement for every new database connection by executing 'PRAGMA foreign_keys = ON'. This ensures that cascading deletes defined in the schema are respected, preventing orphaned chunks when files are deleted or replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where SQLite foreign key constraints were not being enforced, leading to orphaned chunks in the database when files were deleted or replaced.
SQLite does not enforce foreign keys by default, so they must be explicitly enabled for each connection. This change adds
PRAGMA foreign_keys = ONto the database connection initialization.Fix Details
Database::newinsrc/core/db.rsto executePRAGMA foreign_keys = ONimmediately after opening the connection.Verification
I created a reproduction script that simulates the issue:
INSERT OR REPLACEon the file (which deletes the old file row).Before Fix:
The chunk remained orphaned because the cascade delete was not triggered.
After Fix:
The chunk is correctly deleted via the
ON DELETE CASCADEconstraint.Also ran existing tests with
cargo testand they passed.