Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential Out-Of-Memory (OOM) issue when searching in large repositories. Previously,
search_similarwould load all matching embeddings into memory before filtering and sorting. This could consume gigabytes of RAM for large datasets (e.g., >500k chunks).Changes
Vecwith aBinaryHeap(min-heap) to maintain only the top K results in memory.limit * 3, ensuring predictable memory usage regardless of the total number of matching chunks.HeapItemwrapper to handle sorting by similarity in the heap.Memory Impact
For a large index with 500,000 chunks, memory usage for search results is now constant (based on
limit) rather than linear with the number of chunks.Verification