fix: mitigate hash collision risk by using full SHA256 hash#49
Open
fix: mitigate hash collision risk by using full SHA256 hash#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous implementation used only the first 8 bytes (64 bits) of the SHA256 hash for generating project database filenames. This limited the hash space significantly, increasing the risk of collisions via the birthday paradox as the number of projects grows. A collision would result in two different projects sharing the same database file, leading to data corruption.
Solution
This PR changes the
hash_pathfunction insrc/config.rsto use the full SHA256 hash (32 bytes / 64 hex characters) instead of truncating it. This effectively eliminates the risk of accidental collision for all practical purposes.Testing
hash_pathnow returns a 64-character hex string.cargo testto ensure no regressions.