Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds validation to the
server_hostconfiguration option inconfig.rs. Previously, any string was accepted, leading to runtime failures with unclear error messages if users provided invalid hosts like URLs or IPs with ports.Changes
set_server_host.http://).127.0.0.1:8080), instructing users to useserver_portinstead.test_server_host_validationto verify the new validation rules.Testing
test_server_host_validationwhich verifies that:cargo test config::tests::test_server_host_validationsuccessfully.Closes #184