Open
Conversation
This change constrains the cursor position to the visible input area, preventing integer overflow when the input string is longer than the visible area or u16::MAX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where extremely long input strings in the search TUI could cause an integer overflow when calculating the cursor position. The cursor position calculation now clamps the input length to the visible input area width, ensuring it fits within
u16and remains within the bounds of the terminal area.Changes
search_tui.rsto calculatemax_input_widthbased on area width minus borders.input_lento the minimum of the actual input length andmax_input_width, casting strictly tou16only after clamping.set_cursor_positionto use the safe, clamped value.Verification
u16::MAX.