fix: exclude vector arrays from CLI --json output#337
Open
dingguagua996-stack wants to merge 1 commit intoCortexReach:masterfrom
Open
fix: exclude vector arrays from CLI --json output#337dingguagua996-stack wants to merge 1 commit intoCortexReach:masterfrom
dingguagua996-stack wants to merge 1 commit intoCortexReach:masterfrom
Conversation
The --json output for list/search/stats commands included full vector arrays (768-1024 dimensional floats), making output extremely verbose and unreadable. Use a JSON replacer function in formatJson() to automatically filter out 'vector' fields. This is consistent with the export command which already strips vectors (line 888). Fixes CortexReach#302
Collaborator
|
方向对,CLI --json 去掉 vector 数组确实是刚需。 麻烦 rebase 到最新 master(我们刚发了 beta.10),然后补一个 rebase + 补测试后可以合 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--jsonoutput forlist,search, andstatsCLI commands included full vector arrays (768-1024 dimensional floats per entry), making output extremely verbose and unreadable.Changes
Use a JSON replacer function in
formatJson()to automatically filter outvectorfields from all CLI JSON output. This is consistent with theexportcommand which already strips vectors (line 888:vector: undefined).Before
{ "id": "abc123", "text": "Some memory", "vector": [0.023, -0.045, 0.012, ...], // 768+ numbers! ... }After
{ "id": "abc123", "text": "Some memory", ... }Files Changed
cli.tsformatJson()now uses JSON replacer to excludevectorkeyFixes #302