feat: add configurable rerank timeout (rerankTimeoutMs)#371
Open
ggzeng wants to merge 1 commit intoCortexReach:masterfrom
Open
feat: add configurable rerank timeout (rerankTimeoutMs)#371ggzeng wants to merge 1 commit intoCortexReach:masterfrom
ggzeng wants to merge 1 commit intoCortexReach:masterfrom
Conversation
The cross-encoder rerank request timeout was hardcoded at 5 seconds, which is too aggressive for self-hosted rerank services that may need 6-7 seconds to respond. This adds a option to RetrievalConfig and raises the default to 10 seconds. - Add field to RetrievalConfig interface - Use instead of hardcoded 5000 - Backwards compatible: existing configs without the field get 10s default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cross-encoder rerank request timeout was hardcoded at 5 seconds, which is too aggressive for self-hosted rerank services (e.g. HuggingFace TEI via Infinity) that may need 6-7 seconds to respond.
Changes
rerankTimeoutMsoptional field toRetrievalConfiginterface5000withconfig.rerankTimeoutMs ?? 10_000Usage
{ "retrieval": { "rerank": "cross-encoder", "rerankTimeoutMs": 20000 } }Backwards Compatibility
Fully backwards compatible. Existing configs without
rerankTimeoutMswill get the new 10s default.