Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to k256 0.14 pre-release to allow high-S in recover pubkey #2015

Closed
wants to merge 1 commit into from

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Feb 2, 2024

Alternative to #2014 , using a 0.14 pre-release of k256. As discussed in RustCrypto/elliptic-curves#991, no changes to the VerifyingKey::recover_from_digest call are needed.

Requires Rust 1.73.0 or higher

This does not update contracts since that would lead to huge merge conflicts in Lockfiles.

@webmaster128 webmaster128 force-pushed the fix-pubkey-recovery-high-s-0.14 branch from 3b6f279 to dc06e0c Compare February 3, 2024 13:28
Base automatically changed from add-wycheproof to main February 5, 2024 13:03
@webmaster128 webmaster128 changed the title Update to k256 pre-release to allow high-S in recover pubkey Update to k256 0.14 pre-release to allow high-S in recover pubkey Feb 5, 2024
@webmaster128
Copy link
Member Author

Closing in favour of a fresh ticket for later: #2018

@webmaster128 webmaster128 deleted the fix-pubkey-recovery-high-s-0.14 branch February 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant