PoC call function by param_arity #2115
Closed
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
webmaster128
force-pushed
the
call-function-by-arity
branch
from
8ad092b
to
3d86c8c
Compare
|
@kulikthebird FYI this is different approach to the migrate feature you implemented. Instead of trying to call with two arguments and on faiure with three, you can provide a hashmap of arguments. Then the right arguments are provided on the first try. Pro: only one function call required and very flexible for future extensions. Con: some code overhead given that we only have one use case for now. Closing this now as not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.